+ Start a Discussion
davixdavix 

Why my test doesn't 100% coverage ?

Apex code :
public class myClass {
    public ID seekAccount(String e164) {
        ID ref = NULL ;
        List<List< SObject>> searchList = [ FIND :e164 IN PHONE FIELDS RETURNING Account(ID LIMIT 1) ] ;

        Account[] searchAccounts = (Account[])searchList[0];
        for(Account a : searchAccounts)
        {
            ref = a.ID ;
        }
        return ref ;
    }        
}

Why Apex Test Code don't covere 100%, no " ref = a.ID " ?
@isTest
private class myClassTest {
    @isTest
    static void seekAccountTest() {     
        Id elt = null ; 
        Account a = new Account(Phone='33618181800', Name='33618181800') ;
        insert a ;

        myClass test = new myClass() ;
        elt = test.seekAccount('33618181800')  ;
        System.assertNotEquals(null, elt) ;
        System.assertEquals(a.ID, elt) ;
        elt = test.seekAccount('33618181801')  ;
        System.assertEquals(null, elt) ;
    } 
}

But It work if I use this solution, but I don't wish use it, because I must check severals objects :
 
public class myClass {
        public ID seekAccount(String e164) {
            ID ref = NULL ;
            List<Account> searchList = [ SELECT ID FROM Account WHERE Phone=:e164 ] ;
            for(Account a : searchList)
            {
                ref = a.ID ;
            }
            return ref ;
         }        
    }

 
Best Answer chosen by davix
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for SOSL test class
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_SOSL.htm

To ensure that test methods always behave in a predictable way, any Salesforce Object Search Language (SOSL) query that is added to an Apex test method returns an empty set of search results when the test method executes. If you do not want the query to return an empty list of results, you can use the Test.setFixedSearchResults system method to define a list of record IDs that are returned by the search. All SOSL queries that take place later in the test method return the list of record IDs that were specified by the Test.setFixedSearchResults method.

Update your test class like below
@isTest
private class myClassTest 
{
    @isTest
    static void seekAccountTest() 
	{     
        Id elt = null ; 
        Account a = new Account(Phone='33618181800', Name='33618181800') ;
        insert a ;
		
		List<Id> searchResults = new List<Id> {a.Id};
		Test.setFixedSearchResults(searchResults);

        myClass test = new myClass() ;
        elt = test.seekAccount('33618181800')  ;
        System.assertNotEquals(null, elt) ;
		
        System.assertEquals(a.ID, elt) ;
        elt = test.seekAccount('33618181801')  ;
        System.assertEquals(null, elt) ;
		
    } 
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 

All Answers

RaidanRaidan
To test SOSL, you will have to set the fixed result. Your test code will have to call the setFixedSearchResults() method. Here is an example based on your test code (add this after line 7 - insert a; - in your test class):
List<Id> searchResults = new List<Id> {a.Id};
Test.setFixedSearchResults(searchResults);


 
Amit Chaudhary 8Amit Chaudhary 8
Please check below post for SOSL test class
1) https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_SOSL.htm

To ensure that test methods always behave in a predictable way, any Salesforce Object Search Language (SOSL) query that is added to an Apex test method returns an empty set of search results when the test method executes. If you do not want the query to return an empty list of results, you can use the Test.setFixedSearchResults system method to define a list of record IDs that are returned by the search. All SOSL queries that take place later in the test method return the list of record IDs that were specified by the Test.setFixedSearchResults method.

Update your test class like below
@isTest
private class myClassTest 
{
    @isTest
    static void seekAccountTest() 
	{     
        Id elt = null ; 
        Account a = new Account(Phone='33618181800', Name='33618181800') ;
        insert a ;
		
		List<Id> searchResults = new List<Id> {a.Id};
		Test.setFixedSearchResults(searchResults);

        myClass test = new myClass() ;
        elt = test.seekAccount('33618181800')  ;
        System.assertNotEquals(null, elt) ;
		
        System.assertEquals(a.ID, elt) ;
        elt = test.seekAccount('33618181801')  ;
        System.assertEquals(null, elt) ;
		
    } 
}

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you
 
This was selected as the best answer
FearNoneFearNone
change your test class to this:
@isTest
private class myClassTest {
    @isTest
    static void seekAccountTest() {         
        Id elt = null ; 
        Account a = new Account(Phone='33618181800', Name='33618181800') ;
        insert a ;

        Id[] fixedSearchResults= new Id[1];
        fixedSearchResults[0] = a.id;
        System.Test.setFixedSearchResults(fixedSearchResults);
        
        myClass test = new myClass() ;        
        elt = test.seekAccount('33618181800')  ;
        System.assertNotEquals(null, elt) ;
        System.assertEquals(a.ID, elt) ;
        
        System.Test.setFixedSearchResults(null);
        elt = test.seekAccount('33618181801')  ;
        System.assertEquals(null, elt) ;
    } 
}

 
davixdavix
Thanks to the SalesForce community that is alive and always responsive