Apex Code Development You need to sign in to do that
Don't have an account?
Steven Keker 3 Need help with Batchable test class and code coverage
Quite new to Apex here. I manipulated this code found on the forum to create a custom object which will be scheduled to run on the 1st of the month once I can get it to prod. I am running into an issue with the test class:
1) I have an Problem: at Line 0 -> duplicate value found: duplicates value on record with id:
2) The test class appears to save, but when I close it and reopen, all I get is a brand new class
Here is my record create code:
global class CreateParentMRR implements Database.Batchable<SObject>, Database.Stateful{
//implement start method
global Database.QueryLocator start(Database.BatchableContext bc) {
//gather all Parent Accounts that will have a Parent MRR created
String query = 'Select Id, Name, Most_Recent_Parent_MRR__c, Is_a_Parent__c from Account where Is_a_Parent__c = true';
//check to see if the batch is being called from a test class; if record count returned by the query is over 200, the test will fail.
if(Test.isRunningTest())
query += 'limit 200';
return Database.getQueryLocator(query);
}
//implement execute method
global void execute(Database.BatchableContext bc, List<Account> originalrecords){
//loop through the records from the query, create the new Parent MRRs and store them in a list
List<Parent_MRR__c> newrecords = new List<Parent_MRR__c>();
for(Account O1 :originalrecords){ //this is the loop
Parent_MRR__c O2 = new Parent_MRR__c(); //sets up a new record to be created
//prepopulate fields
O2.Name = O1.Name;
O2.Parent_Account__c = O1.ID;
O2.Last_Month_Parent_MRR__c = O1.Most_Recent_Parent_MRR__c;
newrecords.add(O2); //add records to the list
}
//check to see if there are any records to insert; if so, create them
if(!newrecords.isEmpty())
database.insert(newrecords,false);
//newrecords is the list of records put in during the for loop. The 'false' says if one record dails to insert, still insert the rest - all of nothing
}
//implement finish method
global void finish(Database.BatchableContext bc) {}
}
And the scheduler:
global class Schedule_CreateParentMRR implements Schedulable{
global static void execute(SchedulableContext SC){
//runs the batch
CreateParentMRR CPM = new CreateParentMRR();
ID idBatch = Database.executeBatch(CPM);
}
}
And the test:
@isTest(SeeAllData=true)
public class Schedule_CreateProductMRR {
static testMethod void myTest(){
CreateProductMRR CPrM = new CreateProductMRR();
test.startTest();
ID idBatch = Database.executeBatch(CPrM);
test.stopTest();
system.assert(idBatch != null);
}
}
Here is the resource I used: https://success.salesforce.com/answers?id=90630000000CqRCAA0
I am usually quite resourceful when it comes to figure things out but can't seem to get this one. Everything works perfect in my sandbox; frustrating I can't move it to prod. Any help is much appreciated. Thanks!
1) I have an Problem: at Line 0 -> duplicate value found: duplicates value on record with id:
2) The test class appears to save, but when I close it and reopen, all I get is a brand new class
Here is my record create code:
global class CreateParentMRR implements Database.Batchable<SObject>, Database.Stateful{
//implement start method
global Database.QueryLocator start(Database.BatchableContext bc) {
//gather all Parent Accounts that will have a Parent MRR created
String query = 'Select Id, Name, Most_Recent_Parent_MRR__c, Is_a_Parent__c from Account where Is_a_Parent__c = true';
//check to see if the batch is being called from a test class; if record count returned by the query is over 200, the test will fail.
if(Test.isRunningTest())
query += 'limit 200';
return Database.getQueryLocator(query);
}
//implement execute method
global void execute(Database.BatchableContext bc, List<Account> originalrecords){
//loop through the records from the query, create the new Parent MRRs and store them in a list
List<Parent_MRR__c> newrecords = new List<Parent_MRR__c>();
for(Account O1 :originalrecords){ //this is the loop
Parent_MRR__c O2 = new Parent_MRR__c(); //sets up a new record to be created
//prepopulate fields
O2.Name = O1.Name;
O2.Parent_Account__c = O1.ID;
O2.Last_Month_Parent_MRR__c = O1.Most_Recent_Parent_MRR__c;
newrecords.add(O2); //add records to the list
}
//check to see if there are any records to insert; if so, create them
if(!newrecords.isEmpty())
database.insert(newrecords,false);
//newrecords is the list of records put in during the for loop. The 'false' says if one record dails to insert, still insert the rest - all of nothing
}
//implement finish method
global void finish(Database.BatchableContext bc) {}
}
And the scheduler:
global class Schedule_CreateParentMRR implements Schedulable{
global static void execute(SchedulableContext SC){
//runs the batch
CreateParentMRR CPM = new CreateParentMRR();
ID idBatch = Database.executeBatch(CPM);
}
}
And the test:
@isTest(SeeAllData=true)
public class Schedule_CreateProductMRR {
static testMethod void myTest(){
CreateProductMRR CPrM = new CreateProductMRR();
test.startTest();
ID idBatch = Database.executeBatch(CPrM);
test.stopTest();
system.assert(idBatch != null);
}
}
Here is the resource I used: https://success.salesforce.com/answers?id=90630000000CqRCAA0
I am usually quite resourceful when it comes to figure things out but can't seem to get this one. Everything works perfect in my sandbox; frustrating I can't move it to prod. Any help is much appreciated. Thanks!
1) http://amitsalesforce.blogspot.com/search/label/Test%20Class
2) http://amitsalesforce.blogspot.com/2015/06/best-practice-for-test-classes-sample.html
Please try below test class
@isTest public class CreateParentMRRTest { static testMethod void testMethod1() { List<Account> lstAccount= new List<Account>(); for(Integer i=0 ;i <200;i++) { Account acc = new Account(); acc.Name ='Name'+i; acc.Is_a_Parent__c = true; lstLead.add(acc); } insert lstAccount; Test.startTest(); CreateParentMRR obj = new CreateParentMRR(); DataBase.executeBatch(obj); Test.stopTest(); } }Please follow below salesforce Best Practice for Test Classes :-
1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .
Please let us know if this post will help you
@isTest public class CreateParentMRRTest { static testMethod void testMethod1() { Account acc = new Account(); acc.Name ='Name'; acc.Is_a_Parent__c = true; insert acc; Test.startTest(); CreateParentMRR obj = new CreateParentMRR(); DataBase.executeBatch(obj); Test.stopTest(); } }Let us know if this will help you
//check to see if the batch is being called from a test class; if record count returned by the query is over 200, the test will fail.
if(Test.isRunningTest())
query += 'limit 200';
But once I removed that I was able to get 100% coverage. Thanks again.
if(Test.isRunningTest()) query += ' limit 200';I hope that will help you