+ Start a Discussion
kali charankali charan 

Trigger issue while inserting the record

Hi everyone,

   I have written the code for contact,and i have the scenario like for the account if the first child is inserted the amount field of contact should be automatically populated to the parent amount field of account and if the next contact is inserted the check box of the account field should be checked and amount is less with the previous contact it should check the check box of lesser amout.

I am getting the error like

Error: Invalid Data. 
Review all error messages below to correct your data.
Apex trigger UpdateAmount caused an unexpected exception, contact your administrator: UpdateAmount: execution of AfterInsert caused by: System.NullPointerException: Attempt to de-reference a null object: Trigger.UpdateAmount: line 18, column 1

Please fix the issues and if any modifications required.Please help me.

trigger UpdateAmount on Contact (after insert, after update) {
  Map<ID, Account> parentAccs = new Map<ID, Account>(); 
  List<Id> listIds = new List<Id>();
  List<Account> updatedparentAccs = new List<Account>();
  List<contact> COnIds= new List<contact>();
  
   for (contact childObj : Trigger.new) {
    listIds.add(childObj.AccountID);
  }

  parentAccs = new Map<Id, account>([SELECT id, Parent_amount__c,Greater_amount__c,Lesser_Amount__c,Name,(SELECT ID, Amount__c FROM contacts) FROM Account WHERE ID IN :listIds]);
  system.debug('%%%%%%%%%%%'+parentAccs);
  COnIds = [select id,AccountID from contact where AccountID IN :listIds];
  Account myParentOpp;
  
  for (contact con: Trigger.new){
     myParentOpp = parentAccs.get(con.AccountID);
     myParentOpp.Parent_amount__c= con.Amount__c;
     if(COnIds.size()>1 && con.Amount__c>COnIds[0].Amount__c){
     myParentOpp.Greater_Amount__c = true;
     }
     
    updatedparentAccs.add(myParentOpp);
    }
    

  if(!updatedparentAccs.isEmpty()){
  update updatedparentAccs;
  }

}

Thanks.
Amit Chaudhary 8Amit Chaudhary 8
Please try to update your code like below
trigger UpdateAmount on Contact (after insert, after update) 
{

	Set<Id> listIds = new Set<Id>();
	for (contact childObj : Trigger.new) 
	{
		listIds.add(childObj.AccountID);
	}

	Map<ID, Account> parentAccs  = new Map<Id, account>([SELECT id, Parent_amount__c,Greater_amount__c,Lesser_Amount__c,Name,(SELECT ID, Amount__c FROM contacts) FROM Account WHERE ID IN :listIds]);
	
	List<Account> updatedparentAccs = new List<Account>();
	
	for (contact con: Trigger.new)
	{
		if(parentAccs.containskey(con.AccountID))
		{
			 Account  myParentOpp = parentAccs.get(con.AccountID);
			 myParentOpp.Parent_amount__c= con.Amount__c;
			 List<Contact> lstCont = myParentOpp.contacts;
			 
			 if(lstCont.size()>1 && con.Amount__c>lstCont[0].Amount__c) // Please check this logic
			 {
				myParentOpp.Greater_Amount__c = true;
			 }
			 
				updatedparentAccs.add(myParentOpp);
		}
    }
    

	if(	!updatedparentAccs.isEmpty() )
	{
		update updatedparentAccs;
	}

}
Please check below post to trigger
1) http://amitsalesforce.blogspot.com/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail
 
sathishkumar periyasamysathishkumar periyasamy
@kali, why you are using "COnIds[0]"? this will always look first contact of that account. And also there is possibility you will get null pointer exception when there is no contact for that account? What is your actual requirment?