+ Start a Discussion
Vijay@sfdcVijay@sfdc 

write a code with maps

Hello All,
 
  can any one help me with writting the bellow code 
1) by using Map
2) with best pracitces 

trigger UpdatePhone1 on contact (After insert) {
    list<account> acc= new list<account>();
    
    for(contact con:trigger.new)
    {
        account a= [select id, name,phone from account where id=: con.accountid];
        a.phone= con.phone;
        acc.add(a);
    }
    update acc;

}
Best Answer chosen by Vijay@sfdc
Abhijeet Anand 6Abhijeet Anand 6
There you go


trigger UpdatePhone1 on contact (After insert) {
    List<account> accountList = new List<account>();
    Map<Id,Id> contactMap = new Map<Id,Id>();
    
    for(Contact obj : [SELECT Id, AccountId FROM Contact WHERE Id IN : trigger.newmap.keyset()]){
        contactMap.put(obj.Id,obj.AccountId);
    }
    
   if(!contactMap.IsEmpty()){
       for(Contact con : trigger.new){
           Account account = new Account(Id = contactMap.get(con.Id));
           account.phone= con.phone;
           accountList.add(account);
       }
   }
    
    if(!accountList.IsEmpty())
        update accountList;

}

All Answers

Abhijeet Anand 6Abhijeet Anand 6
Hi Vijay,

Hope this helps

trigger UpdatePhone1 on contact (After insert) {
    List<account> accountList = new List<account>();
   
    for(Contact con : trigger.new){
        Account account = new Account(Id = con.AccountId);
        account.phone = con.phone;
        accountList.add(account);
    }
    
    if(!accountList.IsEmpty())
    
        update accountList;

}

Never use a SOQL statement inside a loop.

Thanks
Abhijeet
Vijay@sfdcVijay@sfdc
Thanks abhijeet, is it posilbe to wirte above code using MAP's , if posible can you help me to write above code using map
Abhijeet Anand 6Abhijeet Anand 6
I don't think we really need a Map for this scenario. We have achieved the desire result without any Map only in quite an efficient way.
Making use of Map will only increase the number of lines.

 
Vijay@sfdcVijay@sfdc
I am practicing with maps fr knowledge sake. This is my practice example
Amit Chaudhary 8Amit Chaudhary 8
Please try below code.
trigger UpdatePhone1 on contact (After insert) 
{
    list<account> acc= new list<account>();
	set<Id> setAccId = new Set<ID>();	
	for(contact con:trigger.new)
    {
		if( con.accountid  != null)
		{
			setAccId.add(con.accountid);
		}	
	}
	
	Map<Id,Account> MapAccount = new Map<Id,Account>( [ select id, name,phone from account where id in :setAccId ] );
	
    for(contact con:trigger.new)
    {
		if( con.accountid  != null && MapAccount.containsKey(con.accountid) == true )
		{
			account a= MapAccount.get(con.accountid);
			a.phone= con.phone;
			acc.add(a);
		}	
    }
	if(acc.size() > 0 )
	{
		update acc;
	}
	
}
Please check below post for trigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
Abhijeet Anand 6Abhijeet Anand 6
There you go


trigger UpdatePhone1 on contact (After insert) {
    List<account> accountList = new List<account>();
    Map<Id,Id> contactMap = new Map<Id,Id>();
    
    for(Contact obj : [SELECT Id, AccountId FROM Contact WHERE Id IN : trigger.newmap.keyset()]){
        contactMap.put(obj.Id,obj.AccountId);
    }
    
   if(!contactMap.IsEmpty()){
       for(Contact con : trigger.new){
           Account account = new Account(Id = contactMap.get(con.Id));
           account.phone= con.phone;
           accountList.add(account);
       }
   }
    
    if(!accountList.IsEmpty())
        update accountList;

}
This was selected as the best answer
Vijay@sfdcVijay@sfdc
Thanks Amit Giving best anwer :)
Vijay@sfdcVijay@sfdc
Hello Amit,
I have one small doubt. we are retrieving all the data into map, what if happens it contains lot of data, does not it degrade program performance.

Thanks
 
Amit Chaudhary 8Amit Chaudhary 8
We are fatching only related Account of Contact. Its means if we will execute 200 Contact then only 200 account will come in Map.
 
trigger UpdatePhone1 on contact (After insert) 
{
    list<account> acc= new list<account>();
	set<Id> setAccId = new Set<ID>();	
	for(contact con:trigger.new)
    {
		if( con.accountid  != null)
		{
			setAccId.add(con.accountid);
		}	
	}
	
	Map<Id,Account> MapAccount = new Map<Id,Account>( [ select id, name,phone from account where id in :setAccId ] ); // Here we are fatching associated account with contact
	
    for(contact con:trigger.new)
    {
		if( con.accountid  != null && MapAccount.containsKey(con.accountid) == true )
		{
			account a= MapAccount.get(con.accountid);
			a.phone= con.phone;
			acc.add(a);
		}	
    }
	if(acc.size() > 0 )
	{
		update acc;
	}
	
}

Let us know if you need more help