+ Start a Discussion
RICARDO PALMARICARDO PALMA 

Too many SOQL

Hi,
I'm getting Too many SOQL queries: 101 but my select is not inside of a loop.
trigger MyAccountTrigger on Account (before update) {
any ideas?
Thanks.

if (Trigger.isBefore) { 
        if (Trigger.isUpdate) {
           for (Account aRecord  : trigger.new){
                    if (aRecord.OwnerId != trigger.oldMap.get(aRecord.id).OwnerId){
                    MyAccountClassOwnerChange.Accountownerchanged();
                }
            }
 
        }
}
}

public class MyAccountClassOwnerChange {

    public static void Accountownerchanged(){
        Set<Id> newAccountId = new Set <Id>();
        Set<Id> newAccountOwner = new Set <Id>();
        Date newLastAcctivityDate;
        
        /* Changing the Account Owner this For Loop set the IDs for the new account and new owner id*/  
        for (Account aRecord  : (List<Account>)Trigger.new) {
               newAccountId.add(aRecord.Id);
               newAccountOwner.add(aRecord.OwnerId);
        }
        
        /* Here I'm getting the Max (StartDatetime) which is equal to ActivityDate. I'm not using the ActicityDate because
         * field ActivityDate does not support aggregate operator MAX.
        */
        AggregateResult[] groupedResults = [SELECT max(StartDateTime) maxDate From Event Where Whatid in :newAccountId and Ownerid in :newAccountOwner and Completed_Date__c != null];
        For (AggregateResult ar :groupedResults) {
            newLastAcctivityDate =  Date.valueOf(ar.get('MaxDate'));
        }
        
       /*Here I'm updating the Last Contacted Day with the newLastAcctivityDate
        * Note: an update is not necesary because I'm setting Last Contacted Day value as part of trigger.new and 
        * because the Trigger is a before update, I can set data defore the update is executed.
        */ 
       for (Account aRecord  : (List<Account>)Trigger.new) {
           aRecord.Last_Contacted_Day__c = newLastAcctivityDate;
       }
}
}
Naresh YadavNaresh Yadav
Hi RICARDO PALMA

Actually you are calling your class method in side the loop that causes Too many SOQL queries: 101.
RICARDO PALMARICARDO PALMA
Hi Naresh, 
Thanks for your response. Is there a better way to do it?
Nayana KNayana K
if (Trigger.isBefore) { 
        if (Trigger.isUpdate) {
        
        MyAccountClassOwnerChange.Accountownerchanged();
           
    }

}


public class MyAccountClassOwnerChange {

    public static void Accountownerchanged()
    {
        Set<Id> newAccountId = new Set <Id>();
        Set<Id> newAccountOwner = new Set <Id>();
        Date newLastAcctivityDate;
        
        /* Changing the Account Owner this For Loop set the IDs for the new account and new owner id*/  
        for (Account aRecord  : Trigger.new) 
        {
            // if owner is changed
            if(aRecord.OwnerId != Trigger.oldMap.get(aRecord.Id).OwnerId)
            {
                newAccountId.add(aRecord.Id);
                newAccountOwner.add(aRecord.OwnerId);
            }
               
        }
        
        /* Here I'm getting the Max (StartDatetime) which is equal to ActivityDate. I'm not using the ActicityDate because
         * field ActivityDate does not support aggregate operator MAX.
        */
        AggregateResult[] groupedResults = [SELECT max(StartDateTime) maxDate From Event Where Whatid in :newAccountId and Ownerid in :newAccountOwner and Completed_Date__c != null
        ];
        For (AggregateResult ar :groupedResults) {
            newLastAcctivityDate =  Date.valueOf(ar.get('MaxDate'));
        }
        
       /*Here I'm updating the Last Contacted Day with the newLastAcctivityDate
        * Note: an update is not necesary because I'm setting Last Contacted Day value as part of trigger.new and 
        * because the Trigger is a before update, I can set data defore the update is executed.
        */ 
       for (Account aRecord  : Trigger.new) {
           aRecord.Last_Contacted_Day__c = newLastAcctivityDate;
       }
}
}
Amit Chaudhary 8Amit Chaudhary 8
Just update your trigger like below
if (Trigger.isBefore) 
	{ 
        if (Trigger.isUpdate) 
		{
						MyAccountClassOwnerChange.Accountownerchanged();
 
        }
	}
Please check below post for trigger
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
RICARDO PALMARICARDO PALMA
Thanks you all!!