function readOnly(count){ }
Starting November 20, the site will be set to read-only. On December 4, 2023,
forum discussions will move to the Trailblazer Community.
+ Start a Discussion
CKRCKR 

Need Help with the following trigger on before Insert/update event

Hi EveryOne,
I am a newbee, here is my trigger which is not working as expected,I would like to make this work on both before Insert and before update events,the requirement is whenever an account is either going to be created or updated with its Test_Amount__c  field's value = or > 100000,
then the Rating field should have the value as 'Hot' on both Before insert and Before upadate event.
 
trigger InUpAccts on Account (before insert,before update) {
    
    if (trigger.isbefore && trigger.Isupdate)
    {     
        for (Account A : Trigger.New)
        {  List <Account> Aclist = New List <Account> ();
            System.debug('------------------------>'+Trigger.New);
          
            If (A.Name !=null && A.Test_Amount__c == 100000)
             {   
                System.debug('------------------------>'+A.Test_Amount__c);
                Account Acct = New Account();
                //Acct.Name =
                Acct.Rating = 'Hot';
                Aclist.add(Acct);
             }
            If (Aclist.size()>0)
              {   
                System.debug('------------------------>'+Aclist.size());
                Insert Aclist;
                System.debug('------------------------>'+Aclist);
              } 
            else If (A.Name !=null && A.Test_Amount__c == 100)
            {
            Update Aclist;
            }    
        }
    }
}

 
Amit Chaudhary 8Amit Chaudhary 8
I will suggest you please check below trailhead module to learn about trigger
1) https://developer.salesforce.com/trailhead/module/apex_triggers

Please update your trigger like below
trigger InUpAccts on Account (before insert,before update) 
{
    if (trigger.isbefore && trigger.Isupdate)
    {
        for (Account A : Trigger.New)
        { 
            If (A.Name !=null && A.Test_Amount__c == 100000)
            {   
                Acct.Rating = 'Hot';
            }
        }
    }
}
Please check below post to for trigger best pratice
1) http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object
A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers
If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org. 

3) Context-Specific Handler Methods
Create context-specific handler methods in Trigger handlers

4) Bulkify your Code
Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops
An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops
It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets
The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately
It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs
When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

Thanks
Amit Chaudhary
ABC XYZ 39ABC XYZ 39
Hi Amit, can you pls look at my recent post. I have a similar query related to triggers. I have been trying to find a solution here for sometime, without any luck. Thanks.
CKRCKR
Hi @Amit,

The real intention behind my post here is that there are numerous befor trigger examples over the internet but i did not see the point of bulkifying, because i dont see any lists,sets in the before triggers much that i have seen online before posting here, i am not stating those exmpales were incorrect including the way you have edited the trigger but to keep it simple why haven't you used a list or atleast a set of Accounts in the trigger

Most importantly and i am curious to know you specified only IsUpdate now is this going to work on before insert as well, cause i wnated to work this both on before insert and before update events,moreover you have not used neither a list nor a set not even you have defined the update statement outside the loop,I am asking this because i dont see any of the statements i have read that comes under bulkifying,

could you please put it on your words if you dont mind.. 

Thanks for the help!

CKR 
Jerome RussJerome Russ
Hi CKR, you would need to specify trigger.isInsert as well (on line 3 of Amit's answer). Also, if apex triggers have you confused I would suggest looking in to Process Builder. It is a great tool for simple logic like this example and even some logic that is more complex! The interface is great to use as well.