+ Start a Discussion
Steve Cairney NOWSteve Cairney NOW 

Help writing a test class

Hi all, I have trigger but I'm stuggling to write the test class (I still don't have the experience to do this on my own yet!) Could anyone point me in the right direction please?
 
trigger DoctorTicket on Zendesk__Zendesk_Ticket__c (before insert, before update){
    Zendesk__Zendesk_Ticket__c ticket = trigger.new[0];
    String opname = ticket.Doctor_Name__c;

    // if there's a value populated, get the ID of the record to be related and update the lookup field
    if(opname != null && opname != ''){
        Doctor__c o = [SELECT Id FROM Doctor__c where Name=:opname LIMIT 1]; //query SFDC for a record

        // if an object was returned and that object is different from the current object, update the field
        if(o.ID != null){
            if(o.ID != ticket.Doctor__c){
                ticket.Doctor__c = o.Id;
            }
        }
    }
}

 
Best Answer chosen by Steve Cairney NOW
Amit Chaudhary 8Amit Chaudhary 8
Please let me know if Doctor_Name__c if formula field if that is Text field then please try below code
Please try below code.
 
@isTest 
public class DoctorTicketTest 
{
    static testMethod void testMethod1() 
	{
		Doctor__c doc = new Doctor__c ();
		doc.name ='Test';
		// add all required field
		insert doc;

		Doctor__c doc1 = new Doctor__c ();
		doc1.name ='Test';
		// add all required field
		insert doc1;

		
		Zendesk__Zendesk_Ticket__c zenTick = new Zendesk__Zendesk_Ticket__c();
		zenTick.Doctor_Name__c = 'Test'; 
		// add all required field
		insert 	zenTick;
	
    }
}

Let me know if this will help you
 

All Answers

sai firstsai first
Zendesk__Zendesk_Ticket__c  you are writing the triger on this object , so in test class create this object  with some fields used in the triger and insert that object update that object, your test class will get pass.
Palani_ChinnasamyPalani_Chinnasamy
Hi Steve,

Here is sample test classes for Trigger, Please refer following Salesforce document to write small test classes.

https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/apex_testing_example.htm

If you still have doubt let me know I will give live sample test class to learn quicker

Thanks 
Palani
Steve Cairney NOWSteve Cairney NOW
Hi guys, I'll investigate this and let you know how I get on. 
Amit Chaudhary 8Amit Chaudhary 8
Hi Steve,

Please check below post to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2) http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please try below test class.
@isTest 
public class DoctorTicketTest 
{
    static testMethod void testMethod1() 
	{
		Doctor__c doc = new Doctor__c ();
		doc.name ='Test';
		// add all required field
		insert doc;
		
		Zendesk__Zendesk_Ticket__c zenTick = new Zendesk__Zendesk_Ticket__c();
		zenTick.Doctor_Name__c = doc.id ; // if Doctor_Name__c if formula field plz add lookup field for Doctor
		// add all required field
		insert 	zenTick;
	
    }
}



Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
Steve Cairney NOWSteve Cairney NOW
Hi Amit, that looks good. 57% coverage. The only section that isn't covered in the trigger is the below
 
if(o.ID != null){
            if(o.ID != ticket.Doctor__c){
                ticket.Doctor__c = o.Id;

 
Steve Cairney NOWSteve Cairney NOW
There was also a failure with that
 
System.DmlException: Insert failed. First exception on row 0; first error: CANNOT_INSERT_UPDATE_ACTIVATE_ENTITY, DoctorTicket: execution of BeforeInsert

caused by: System.QueryException: List has no rows for assignment to SObject

Trigger.DoctorTicket: line 7, column 1: []

 
Amit Chaudhary 8Amit Chaudhary 8
Update your code like below
@isTest 
public class DoctorTicketTest 
{
    static testMethod void testMethod1() 
	{
		Doctor__c doc = new Doctor__c ();
		doc.name ='Test';
		// add all required field
		insert doc;

		Doctor__c doc1 = new Doctor__c ();
		doc1.name ='Test';
		// add all required field
		insert doc1;

		
		Zendesk__Zendesk_Ticket__c zenTick = new Zendesk__Zendesk_Ticket__c();
		zenTick.Doctor__c = doc.id ; 
		// add all required field
		insert 	zenTick;
	
		zenTick.Doctor__c = doc1.id ; 
		update zenTick;
    }
}
Let us know if this will help you
 
Steve Cairney NOWSteve Cairney NOW
Interesting, that actually dropped some coverage

This line is no longer covered
 
Doctor__c o = [SELECT Id FROM Doctor__c where Name=:opname LIMIT 1]; //query SFDC for a record

 
Amit Chaudhary 8Amit Chaudhary 8
Please let me know if Doctor_Name__c if formula field if that is Text field then please try below code
Please try below code.
 
@isTest 
public class DoctorTicketTest 
{
    static testMethod void testMethod1() 
	{
		Doctor__c doc = new Doctor__c ();
		doc.name ='Test';
		// add all required field
		insert doc;

		Doctor__c doc1 = new Doctor__c ();
		doc1.name ='Test';
		// add all required field
		insert doc1;

		
		Zendesk__Zendesk_Ticket__c zenTick = new Zendesk__Zendesk_Ticket__c();
		zenTick.Doctor_Name__c = 'Test'; 
		// add all required field
		insert 	zenTick;
	
    }
}

Let me know if this will help you
 
This was selected as the best answer
Steve Cairney NOWSteve Cairney NOW
Hi Amit, that was perfect (Doctor_Name__c is a text field)

That's an amazingly simply class, did you add 2 Doctor__c so the List in the trigger had something to reference?