+ Start a Discussion
AnjaneyluAnjaneylu 

Test class issue for this trigger. Not covering if conditions....

trigger Alumni_Company_Trigger on Company__c (before insert, before update, after insert,after update ){
 if(trigger.isupdate){
    	 set<id> comids = new set<id>();
         list<job__c> lstjb = new list<job__c>();
           for(Company__c com : trigger.new){
               if(com.Industry__c != ''){
             if(com.Industry__c != trigger.oldmap.get(com.Id).industry__c)
             {
                 comids.add(com.id);
             }
               }
               else{} 
         }
              list<job__c> jblist = [select id, Company__r.Name, Industry__c from job__c where company__r.id  in : comids];
              system.debug('the list is having  ---->'+jblist);
              for(Company__c com : trigger.new){   
           	  for(job__c jb : jblist){
                 if(com.Industry__c == 'OTH')
                 {
                     jb.industry__c = 'Other';
                   
                  }
                 else if(com.Industry__c == 'CIP')
                 {
                     jb.Industry__c = 'Consumer and Industrial Products';
                   
                 }
                  else if(com.Industry__c == 'E & R')
                 {
                     jb.Industry__c = 'Energy and Resources';
                 
                 }
                  else if(com.Industry__c == 'FED')
                 {
                     jb.Industry__c = 'Federal';
              
                 }
                 else if(com.Industry__c == 'FS')
                 {
                     jb.Industry__c = 'Financial Services';
                   
                 }
                 else if(com.Industry__c == 'CIP')
                 {
                     jb.Industry__c = 'Consumer and Industrial Products';
                    
                 }
                 else if(com.Industry__c == 'LSHC')
                 {
                     jb.Industry__c = 'Life Sciences and Health Care';
                    
                 }
                 else if(com.Industry__c == 'PS')
                 {
                     jb.Industry__c = 'Public Sector';
                    
                 }
                 else if(com.Industry__c == 'TMT')
                 {
                     jb.Industry__c = 'Technology, Media and Telecom';
                  
                 }
                else if(com.Industry__c == 'NONE')
                 {
					jb.Industry__c = '';
                    
                 }
                  lstjb.add(jb);
             }
             
         }
        if(lstjb.size()>0)
        {
        update lstjb;
        }
        else{}
    }
}

Thanks in advance
Anji 
Best Answer chosen by Anjaneylu
Amit Chaudhary 8Amit Chaudhary 8
Please update your test class like below
@isTest
public class CompanyTriggerHandler_AT_Test
{
	public static testmethod void  Method1()
	{
		
		Company__c comp = new Company__c();
			comp.Name='abc';
			comp.DUNS_Number__c='120459709';
			comp.MDR_Parent_Company__c='xyz';
			comp.Industry__c = 'OTH';
		insert comp;
		
		job__c jb = new job__c ();
			jb.name= 'Test';
			jb.company__c = comp.id;
			jb.AR_Company_Name__c = 'Test';
			jb.AR_Primary_Location_City__c = 'Test location';
			jb.CCL_Contact_for_company_if_applicable__c = 'Test Company contact';
			jb.Email__c = 'test@deloitte.com';
			jb.Description__c ='test';
			jb.AR_Requirements__c = 'TEst Requirements';
			jb.Source__c = 'External';
			jb.industry__c = 'Others';
		insert jb;
		
		comp.Industry__c = 'CIP';
		update comp;
		
		comp.Industry__c = 'E & R';
		update comp;

		comp.Industry__c = 'FED';
		update comp;
		
		comp.Industry__c = 'FS';
		update comp;

		comp.Industry__c = 'CIP';
		update comp;

		comp.Industry__c = 'LSHC';
		update comp;

		comp.Industry__c = 'PS';
		update comp;
		
		comp.Industry__c = 'TMT';
		update comp;

		comp.Industry__c = 'NONE';
		update comp;

	}
}
Please check below post to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2)  http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary

All Answers

AnjaneyluAnjaneylu
The test class written for this one is
 
@isTest
public class CompanyTriggerHandler_AT_Test
{
public static testmethod void  Method1()
{
    
    
    Company__c comp = new Company__c();
    comp.Name='abc';
    comp.DUNS_Number__c='120459709';
    comp.MDR_Parent_Company__c='xyz';
    comp.Industry__c = 'OTH';
    insert comp;
    
    job__c jb = new job__c ();
    jb.name= 'Test';
    jb.company__c = comp.id;
    jb.AR_Company_Name__c = 'Test';
    jb.AR_Primary_Location_City__c = 'Test location';
    jb.CCL_Contact_for_company_if_applicable__c = 'Test Company contact';
    jb.Email__c = 'test@deloitte.com';
    jb.Description__c ='test';
    jb.AR_Requirements__c = 'TEst Requirements';
    jb.Source__c = 'External';
    jb.industry__c = 'Others';
    insert jb;
    
    
     set<id> comids  = new set<id>();
   	 comids.add(comp.Id);
	 List<Company__c> company = new List<Company__c>();
	 company.add(comp);
     list<job__c> lst = [select id, company__r.name, industry__c from job__c where company__r.id in: comids];
}}

It is not covering if Conditions..
So kindly suggest me..

Thanks
Anji
Amit Chaudhary 8Amit Chaudhary 8
Please update your test class like below
@isTest
public class CompanyTriggerHandler_AT_Test
{
	public static testmethod void  Method1()
	{
		
		Company__c comp = new Company__c();
			comp.Name='abc';
			comp.DUNS_Number__c='120459709';
			comp.MDR_Parent_Company__c='xyz';
			comp.Industry__c = 'OTH';
		insert comp;
		
		job__c jb = new job__c ();
			jb.name= 'Test';
			jb.company__c = comp.id;
			jb.AR_Company_Name__c = 'Test';
			jb.AR_Primary_Location_City__c = 'Test location';
			jb.CCL_Contact_for_company_if_applicable__c = 'Test Company contact';
			jb.Email__c = 'test@deloitte.com';
			jb.Description__c ='test';
			jb.AR_Requirements__c = 'TEst Requirements';
			jb.Source__c = 'External';
			jb.industry__c = 'Others';
		insert jb;
		
		comp.Industry__c = 'CIP';
		update comp;
		
		comp.Industry__c = 'E & R';
		update comp;

		comp.Industry__c = 'FED';
		update comp;
		
		comp.Industry__c = 'FS';
		update comp;

		comp.Industry__c = 'CIP';
		update comp;

		comp.Industry__c = 'LSHC';
		update comp;

		comp.Industry__c = 'PS';
		update comp;
		
		comp.Industry__c = 'TMT';
		update comp;

		comp.Industry__c = 'NONE';
		update comp;

	}
}
Please check below post to learn about test classes
1) http://amitsalesforce.blogspot.in/search/label/Test%20Class
2)  http://amitsalesforce.blogspot.in/2015/06/best-practice-for-test-classes-sample.html

Please follow below salesforce Best Practice for Test Classes :-

1. Test class must start with @isTest annotation if class class version is more than 25
2. Test environment support @testVisible , @testSetUp as well
3. Unit test is to test particular piece of code working properly or not .
4. Unit test method takes no argument ,commit no data to database ,send no email ,flagged with testMethod keyword .
5. To deploy to production at-least 75% code coverage is required 
6. System.debug statement are not counted as a part of apex code limit.
7. Test method and test classes are not counted as a part of code limit
9. We should not focus on the  percentage of code coverage ,we should make sure that every use case should covered including positive, negative,bulk and single record .
Single Action -To verify that the the single record produces the correct an expected result .
Bulk action -Any apex record trigger ,class or extension must be invoked for 1-200 records .
Positive behavior : Test every expected behavior occurs through every expected permutation , i,e user filled out every correctly data and not go past the limit .
Negative Testcase :-Not to add future date , Not to specify negative amount.
Restricted User :-Test whether a user with restricted access used in your code .
10. Test class should be annotated with @isTest .
11 . @isTest annotation with test method  is equivalent to testMethod keyword .
12. Test method should static and no void return type .
13. Test class and method default access is private ,no matter to add access specifier .
14. classes with @isTest annotation can't be a interface or enum .
15. Test method code can't be invoked by non test request .
16. Stating with salesforce API 28.0 test method can not reside inside non test classes .
17. @Testvisible annotation to make visible private methods inside test classes.
18. Test method can not be used to test web-service call out . Please use call out mock .
19. You can't  send email from test method.
20.User, profile, organization, AsyncApexjob, Corntrigger, RecordType, ApexClass, ApexComponent ,ApexPage we can access without (seeAllData=true) .
21. SeeAllData=true will not work for API 23 version eailer .
22. Accessing static resource test records in test class e,g List<Account> accList=Test.loadData(Account,SobjectType,'ResourceName').
23. Create TestFactory class with @isTest annotation to exclude from organization code size limit .
24. @testSetup to create test records once in a method  and use in every test method in the test class .
25. We can run unit test by using Salesforce Standard UI,Force.com IDE ,Console ,API.
26. Maximum number of test classes run per 24 hour of period is  not grater of 500 or 10 multiplication of test classes of your organization.
27. As apex runs in system mode so the permission and record sharing are not taken into account . So we need to use system.runAs to enforce record sharing .
28. System.runAs will not enforce user permission or field level permission .
29. Every test to runAs count against the total number of DML issued in the process .


Please let us know if this post will help you

Thanks
Amit Chaudhary
This was selected as the best answer
AnjaneyluAnjaneylu
Thanks Amit for your great reply..
now i got the solution...

Anji