I have a VF page that uses an apex:repeat block with inputFields and actionSupport. If the action is fired the data is transmitted to the controller. So from that point of view everything is fine.
However I'd like to do some work in the setter, checking if some special fields are changed in fact.
See this very simple example that illustrates the problem
public with sharing class Testing {
public List<Account> values { get { System.debug('GETTER' + this.values); return this.values; }
set {
System.debug('SETTER' + value);
// never get to this point!!! this.values = value; } }
public String inputValue { get; set; } public String outputValue { get; set; }
public Testing() { System.debug('Start Testing class'); /* values = new List<String>(); values.add('One'); values.add('Two'); values.add('Three'); */ values = [Select Id, Name from Account limit 3]; }
What happens is that the getter of 'values' is called and the 'onchange' event fires perfectly. The rerender renders the new value of the field in the 'outputText'. Fine, BUT the setter of 'values' is never called and I'd like to do some comparison of the record returned with the actual one before setting the new one.
I found in the VF develper guide that the setter is not necessary not therefore not necesarrily called.
<qoute>
While a getter method is always required to access values from a controller, it is not always necessary to include a setter method to pass values into a controller. If a Visualforce component is bound to an sObject that is stored in a controller, the sObject's fields are set automatically if changed by the user, as long as the sObject is saved or updated by a corresponding action method.<quote>
Can I somehow force the setter being called to mark the sObject "as dirty"? The point is that I read the values from the sObject at first and the user is able to change it. In case of changes I need some additional steps on the next pages which aren't necessary otherwise.
I have a VF page that uses an apex:repeat block with inputFields and actionSupport. If the action is fired the data is transmitted to the controller. So from that point of view everything is fine.
However I'd like to do some work in the setter, checking if some special fields are changed in fact.
See this very simple example that illustrates the problem
public with sharing class Testing {
public List<Account> values { get { System.debug('GETTER' + this.values); return this.values; }
set {
System.debug('SETTER' + value);
// never get to this point!!! this.values = value; } }
public String inputValue { get; set; } public String outputValue { get; set; }
public Testing() { System.debug('Start Testing class'); /* values = new List<String>(); values.add('One'); values.add('Two'); values.add('Three'); */ values = [Select Id, Name from Account limit 3]; }
What happens is that the getter of 'values' is called and the 'onchange' event fires perfectly. The rerender renders the new value of the field in the 'outputText'. Fine, BUT the setter of 'values' is never called and I'd like to do some comparison of the record returned with the actual one before setting the new one.
I found in the VF develper guide that the setter is not necessary not therefore not necesarrily called.
<qoute>
While a getter method is always required to access values from a controller, it is not always necessary to include a setter method to pass values into a controller. If a Visualforce component is bound to an sObject that is stored in a controller, the sObject's fields are set automatically if changed by the user, as long as the sObject is saved or updated by a corresponding action method.<quote>
Can I somehow force the setter being called to mark the sObject "as dirty"? The point is that I read the values from the sObject at first and the user is able to change it. In case of changes I need some additional steps on the next pages which aren't necessary otherwise.
There were a few times I thought I may have been literally losing my mind trying to isolate this issue but I was finally able to nail down the steps to reproduce (and solution). Sometimes the param value is not being assign to the variable in the controller.
Here is the code to reproduce. I tried to make it as short as possible but sorry it is still a little long, see steps below code:
List<oppWrapper> opps = new List<oppWrapper>(); List<SelectOption> stages; public ID changedOpp {get; set;} public string sortColumn {get; set;} Map<String,String> sortOrder = new Map<String,String>();
//Constructor public paramBug(){ for(Opportunity opp : [select Id, Name, StageName from Opportunity limit 10]){ opps.add(new oppWrapper(opp)); } }
public List<oppWrapper> getOpps(){ return opps; }
public void change(){ for(oppWrapper o : getOpps()){ if(o.opp.Id == changedOpp){ o.status = 'modified'; } } }
public Boolean getShowTable(){ Boolean show = true; if(opps.size() == 0 ){ show = false; } return show; }
public void sortTable(){ transient List<oppWrapper> sortedOpps = new List<oppWrapper>(); transient Map<String, List<oppWrapper>> stringMap = new Map<String, List<oppWrapper>>();
system.debug('--------------This is the debug line to watch--------------------'); system.debug('sColumn: ' + sortColumn);
public Opportunity opp {get; set;} public String status {get; set;}
//Contructor public oppWrapper(Opportunity opp){ this.opp = opp; } } }
First let's show it working correctly: 1) Open up this page and open the System Log. 2) Click the Stage Name header. This passes a param to the variable "sortColumn" in the controller and calls the action method sortTable(). 3) Monitoring the debug log you can see that this is correctly being passed over: line 41, column 9: sColumn: StageName
Now let's show it not working: 1) Reload the page. 2) Change the Stage of the first opp in the table. This runs the change() method in the controller and rerenders the contents of the Status column. A 'Y' should appear in the row of the edited opp. 3) Click the Stage header to sort. The table will disappear because the sort logic did not execute. If you look at the system log you can see that the param was not passed to the controller and sortColumn is null: line 41, column 9: sColumn: null
Now the fix. I don't know why or how this fixes it but it does. Simply adding the name attribute to the param component does the trick. It doesn't even matter what the name is, just as long as it is there:
Code:
Change this:
<apex:param value="StageName" assignTo="{!sortColumn}" />
to this:
<apex:param name="asdfasd" value="StageName" assignTo="{!sortColumn}" />
and it works.
So there you go. I'm pretty sure this is a bug but if it's not I'll modify the title.
